Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mls): fetch and set mls-removal keys for 1on1 conversations (WPB-10743) #3020

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

mchenani
Copy link
Member

@mchenani mchenani commented Sep 19, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Fetch and set removal-keys from the get-oneonone-conversation response for 1on1 conversations and only APIV6

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarcloud bot commented Sep 19, 2024

@mchenani mchenani added echoes: features End-user visible changes intended to create customer value and removed echoes: bugs Technical or functional defects in the product labels Sep 19, 2024
@echoes-hq echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Sep 19, 2024
Copy link
Contributor

github-actions bot commented Sep 19, 2024

Test Results

2 918 tests   2 900 ✔️  3m 59s ⏱️
       7 suites       18 💤
       7 files           0

Results for commit 78ec046.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 19, 2024

Datadog Report

All test runs af5f111 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
kalium-ios 0 0 0 2805 123 1.3s Link
kalium-jvm 0 0 0 2958 107 5.4s Link

@mchenani mchenani merged commit d491f95 into release/android-cycle-4.6 Sep 19, 2024
22 checks passed
@mchenani mchenani deleted the fix/mls-1on1-removal-keys branch September 19, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: bugs Technical or functional defects in the product echoes: features End-user visible changes intended to create customer value 🚨 Potential breaking changes 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants